Jump to content


Dynamic code for eye-catcher, weird issue if lang Portuguese


7 replies to this topic

#1 john79

    Member

  • Members
  • PipPip
  • 10 posts

Posted 27 November 2017 - 09:08 AM

Hello,
I have the widgets set as usual, nothing touched...

only that in Portuguese fails,
that is, the eye-catcher doesn't get the correct language and shows the translations in the default language (or browser lang, I don't know)

Also, I noticed that you changed the generated code from link generator

eg. you added:
<!-- PASS THRU DATA OBJECT -->
<script type="text/javascript">
var lz_data = {overwrite:false,language:'pt'};
</script>
<!-- PASS THRU DATA OBJECT -->

this wasn't there before, is it really needed? At the moment, the other buttons work fine without that,
I didn't try with the PT button yet inserting this specific code, but that's it.

Thanks

#2 Patrick Keil

    Administrator

  • Administrators
  • 3355 posts
  • LocationSingen, Germany

Posted 27 November 2017 - 09:15 AM

Hi,

Thanks for bringing this to our attention. PT translation works fine for me, I can't reproduce this.

Quote

this wasn't there before, is it really needed?
Yes. If you see problems, please replace your existing code with the code from the Link Generator.

If that does not help, please provide step-by-step instruction on how to reproduce this issue.

Cheers.

#3 john79

    Member

  • Members
  • PipPip
  • 10 posts

Posted 27 November 2017 - 09:36 AM

well, adding that code it works :mrgreen:

the problem is that if that's dynamic, it should be dynamic...

so, if an added code is needed, you should notify your clients and say:
"please, after this server version update, the dynamic code format changed...so you should edit your eye catcher code"
otherwise, issues like this could be there...

thank you

#4 john79

    Member

  • Members
  • PipPip
  • 10 posts

Posted 27 November 2017 - 09:43 AM

p.s.: also, about this "dynamic" code, I noticed that now the old generated links don't report the social media options as before, now they are empty (not set)

but before they were correctly set
and the social media links are there on the html page, anyway...

so, the client doesn't retrieve the social media links, but evidently they are stored on database...
I can't know after what update this happened

#5 Patrick Keil

    Administrator

  • Administrators
  • 3355 posts
  • LocationSingen, Germany

Posted 27 November 2017 - 10:08 AM

You can update existing dynamic codes, just open them in The Link Generator and save them again (hit ok).

Quote

so, if an added code is needed, you should notify your clients and say:
There's a release notes file in the .zip.

We are not changing things for fun and we don't do this very often. I know, it's annoying to update the code but sometimes it's just necessary.

#6 john79

    Member

  • Members
  • PipPip
  • 10 posts

Posted 27 November 2017 - 10:27 AM

ok, thanks

Quote

the old generated links don't report the social media options as before, now they are empty (not set)

what about this, please?

#7 Patrick Keil

    Administrator

  • Administrators
  • 3355 posts
  • LocationSingen, Germany

Posted 28 November 2017 - 07:54 AM

Why old codes?

If you have problems with old codes please try to recreate them.

#8 john79

    Member

  • Members
  • PipPip
  • 10 posts

Posted 28 November 2017 - 11:06 AM

Please, try to avoid recreating codes if dynamic, that's the point.

A user could have many codes, it should just retrieve the database value there if already set.

Do you create a database field or is it a local stored value? For your info, I'm on the Windows APP.
Anyway, if empty...that means something's wrong.

Thanks





1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users